Latest CVS: disklabel broken?

[Alexander Kabaev]

On Thu, Jul 29, 2004 at 05:14:44PM -0700, Jeremy Chadwick wrote:
> Minor typo/clarification: the transition problem lies between boot1
> and boot2, it seems.
> 
> On one of the machines (which uses boot1 across serial console),
> the system reports "Invalid partition" when trying to boot from --
> and yes, this is not a typo -- 0:ad(0,`).  Manually typing in the
> correct device (which is 0:ad(0,a)) causes the machine to spit out
> an exception error and reboot automatically.
> 
> Just wanted to clarify on that point.
> 

GCC 3.4 seems to be very likely cause of this problem. I guess your only
option is to get boot2 file from a system which predates GCC 3.4 and 
install in on broken boxes.

I am trying to find the likely cause of this failure. The very first
idea I managed to think of is that your problem is yet another fallout
from new GCC unit-at-a-time optimisation mode. Could you please test
an attached patch and report results here?


Index: Makefile
===================================================================
RCS file: /home/ncvs/src/sys/boot/i386/boot2/Makefile,v
retrieving revision 1.55
diff -u -r1.55 Makefile
--- Makefile	17 Feb 2004 07:13:03 -0000	1.55
+++ Makefile	30 Jul 2004 00:31:37 -0000
@@ -22,6 +22,7 @@
 
 CFLAGS=	-Os \
 	-fno-guess-branch-probability -fomit-frame-pointer\
+	-fno-unit-at-a-time \
 	-mno-align-long-strings \
 	-mrtd \
 	-D${BOOT2_UFS} \