install crashes on ThinkPad T41

[Tai-hwa Liang]

On Thu, 15 Jul 2004, Dan Langille wrote:
> On 15 Jul 2004 at 9:20, Dan Langille wrote:
>
> > Gidday,
> >
> > I've tried several -current snapshots on this IBM ThinkPad T41
> > (2004.05.24, 2004.06.11, 2004.07.07, and 2004.07.14).  All fail, but
> > at different steps.  I'll report upon 2004.07.14 but will provide
> > information for the others if requested.
> >
> >
> > 5.2.1-RELEASE is installed on this laptop.  It runs fine.  I have
> > attached the output of /var/run/dmesg.boot from that.
> >
> > I have also included the output of dmidecode.
> >
> > 2004.07.14 crashes during probing.  Details of the traceback are at:
> > http://www.langille.org/IBM-ThinkPad-T41-current-2004.07.14-trace.jpg
>
> Just in case that was an installer problem, I cvsup'd to 2004.07.06
> build world, made a kernel, and tried to boot it.  It got a fatal
> trap 12.  Details at
>
> http://www.langille.org/ibm-thinkpad-t41-current-2004-07-06-panic.jpg

  After applying following hacks, my T40 seems to survive from the
ADAPI_IDENTIFY failure(single user mode prompt at least). However,
it still crashed in multiuser mode(while the rc scripts were invoking
some programs such like usbd).

  Note that this patch was generated from an old -CURRENT, you may have to
tweak it before applying directly on recent -CURRENT.

--- /home/avatar/ncvs/src/sys/dev/ata/ata-all.c	Wed Jun 23 22:15:24 2004
+++ /sys/dev/ata/ata-all.c	Sat Jul  3 23:28:54 2004
@@ -572,6 +577,11 @@
 		ata_queue_request(request);
 		if (!(error = request->result))
 		    break;
+	    }
+	    if (error)
+	    {
+		ata_prtdev(atadev, "failing requests on channel unit %d\n", request->device->channel->unit);
+		ata_fail_requests(request->device->channel, atadev);
 	    }
 	    ata_free_request(request);
 	}