Some netgraph node global locking patches
Gleb Smirnoff
glebius at freebsd.org
Wed Jul 14 11:42:44 PDT 2004
On Wed, Jul 14, 2004 at 08:36:01PM +0200, Poul-Henning Kamp wrote:
P> >Yes it does. But qsort() already used in ng_ppp is as much recursive as
P> >qsort_r() is. It will help us to get rid of global variable.
P> >I Cc phk@ to this mail, because he copied qsort() to libkern from libc.
P>
P> It was put there to get rid of a couple of badly implemented bubble
P> sorts.
P>
P> It is true that qsort() is recursive, but it is limited to log2(N)
P> levels and kernel programmers hopefully don't routinely sort arrays
P> of hundreds of things in the kernel.
>From a snap view I see no problems copying qsort_r() to libkern. What
do you think? It will help us to get rid of global in ng_ppp.
--
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
More information about the freebsd-current
mailing list