recent libalias changes

David Malone dwmalone at maths.tcd.ie
Tue Jul 6 04:48:20 PDT 2004


On Tue, Jul 06, 2004 at 01:25:45PM +0200, des at des.no wrote:
> the code I replaced has casts on the lvalue, which is not allowed.

The cast seems to be in the expression leading to the lvalue, but
not on the lvalue itself. That is,

	((char *)p)[0] = 1;	/* cast in expression */
	(char)p[1] = 1;		/* cast in lvalue */

I think the former is permitted, though it may not always be wise.

> >                     The while loop that is immediately above it
> > looks risky though, as this function is probably called with a
> > struct ip * somewhere.
> 
> yes, that's what I think may need rewriting.

Ah, grand...

	David.


More information about the freebsd-current mailing list