buildworld failure in /usr/src/sys/boot/i386/boot2 this morning

[David O'Brien]

On Tue, Feb 17, 2004 at 06:28:24PM +0200, Ruslan Ermilov wrote:
> On Tue, Feb 17, 2004 at 07:52:32AM -0800, David O'Brien wrote:
> > On Tue, Feb 17, 2004 at 09:17:19AM +0200, Ruslan Ermilov wrote:
> > > On Mon, Feb 16, 2004 at 04:13:24PM -0800, David O'Brien wrote:
> > > > On Tue, Feb 17, 2004 at 07:08:54AM +1100, Bruce Evans wrote:
> > > > > On Mon, 16 Feb 2004, Fritz Heinrichmeyer wrote:
> > > > > This problem seems to be caused by a recent repo-copy of sio.S from sio.s.
> > > > > sio.s works, but sio.S is preferred although it has not been connected to
> > > > > the build.
> > > > 
> > > > I rm'ed sio.S as I didn't see anything in it requiring the C
> > > > preprocessor.
> > > > 
> > > You'd better ask me.  :-(
> > >
> > > Anyway, I've restored this file and fixed the build -- it was
> > > a work-in-progress awaiting repo-copies to be complete.
> > 
> > Where are you headed with this?  The file works fine using straight 'as'.
> > Why do we need to bring the C preprocessor into this?
> >  
> Because it's being preprocessed.  Formerly it was handled by
> AFLAGS, now it's handled by CFLAGS.  The tendency is to get
> rid of as many custom make rules in sys/boot/ makefiles as we
> can.  Thanks for asking.

Why is getting rid of custom make rules overriding using the simplest
tool for the job?   AFLAGS was fine, there is no need to bring the C
preprocssor into this.

-- 
-- David  (obrien at FreeBSD.org)