WITNESS broken in subr_witness.c 1.168

[John Baldwin]

On Tuesday 03 February 2004 08:10 am, Bruce Evans wrote:
> % RCS file: /home/ncvs/src/sys/kern/subr_witness.c,v
> % Working file: subr_witness.c
> % head: 1.168
> % ...
> % ----------------------------
> % revision 1.168
> % date: 2004/02/02 22:15:17;  author: jhb;  state: Exp;  lines: +2 -1
> % - Assert that witness_cold is not true in enroll().
> % - Only check witness_watch once in enroll().
> %
> % Reported by:	ru (2)
> % ----------------------------
>
> This is equivalent to asserting that 1 is not true in enroll(), since
> enroll() is always called from witness_initialize() before the latter
> has set witness_cold to 0.

Oof.

> The quick fix is to remove the assertion.

Agreed.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org