bsdtar core dumps
kientzle at freebsd.org
Wed Aug 25 20:36:42 PDT 2004
Sean McNeil wrote:
> On Wed, 2004-08-25 at 11:17, David O'Brien wrote:
>>On Tue, Aug 24, 2004 at 03:17:28PM -0700, Sean McNeil wrote:
>>>>>SM>> You cannot use a va_list twice. As soon as someone call
>>>>>va_arg() on the SM>> ap all the aps in the calling functions get
>>>>>invalid. The only thing that SM>> can and must be done is that the
>>>>>function that did the va_start() must SM>> call va_end.
>>>I missed one in vfwprintf.c. I needs a va_end(orgap) just like above.
>>>Also, I've searched all of src and found one additional place that there
>>>is a va_copy without a va_end.
>>>All other uses appear to be properly matched.
>>Can you please make a new, complete patch?
>>I'll commit it ASAP.
> Thanks David,
> Here are are the patches of all unmatched/missing va_copy/va_end and
> core dump fix to libarchive:
Since David hasn't had a chance to do this yet,
I've gone ahead and committed the libarchive fix.
If David doesn't beat me to it, I'll get the rest
of it committed in the next couple of hours.
Thanks so much for your hard work on this, Sean.
More information about the freebsd-current