BETA1 5.3 make world DESTDIR failure

[Ruslan Ermilov]

On Wed, Aug 25, 2004 at 10:37:07AM -0700, David O'Brien wrote:
> On Wed, Aug 25, 2004 at 04:47:22PM +0300, Ruslan Ermilov wrote:
> > as IMAKEENV (from Makefile.inc1) doesn't utilize DESTDIR.  I think I
> > know how to fix "make world DESTDIR=/foo" to make it work again -- we
> > need to convert all DESTDIR uses in Makefile.inc1 to be command-line
> > variables.  I'm currently testing this patch, and it looks promising:
> 
> Please also test 'make world' without DESTDIR in /etc/make.conf, but with
> 1. "HISTORICAL_MAKE_WORLD=yes" in /etc/make.conf
> 2. env HISTORICAL_MAKE_WORLD=yes make world
> before committing.
> 
That's pointless for this change.  If HISTORICAL_MAKE_WORLD is defined
and DESTDIR is not (irrelevant where), "make world" is just equivalent
to "make buildworld" followed by "make installworld".  Clearly, "make
buildworld" without DESTDIR works with and without this change.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20040825/e95380de/attachment.bin