Syncer giving up on buffers for ext2fs

[Steven Smith]

> > the bug 'Syncer "giving up" on buffers and ext2 filesystems'
> > (PR kern/56675
> > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/56675)
> > has existed for almost a year, and i have tested in a recent
> > snapshot (18th August) and it still exists, will this bug be fixed
> > for 5.3? seems to be quite an important bug.
> It would be nice if someone could come up with a patch, even a quick one.
Well, the attached seems to solve the problem for me, but I'm not
convinced that it doesn't create other ones elsewhere.

Steven Smith,
sos22 at cantab.net
-------------- next part --------------
Index: kern_shutdown.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/kern_shutdown.c,v
retrieving revision 1.163
diff -u -r1.163 kern_shutdown.c
--- kern_shutdown.c	15 Aug 2004 19:17:23 -0000	1.163
+++ kern_shutdown.c	23 Aug 2004 13:45:23 -0000
@@ -285,6 +285,15 @@
 		waittime = 0;
 
 		sync(&thread0, NULL);
+
+		/* SOS22: Moved this to before the sync stage so that
+		   ext2 unmounts cleanly when we're shutting down.  I
+		   don't know whether this is actually safe, but it
+		   does appear to solve the problem without doing
+		   anything obviously bad. */
+		if (panicstr == 0) {
+			vfs_unmountall();
+		}
 
 		/*
 		 * With soft updates, some buffers that are
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20040823/201b4faa/attachment.bin