code cleanup

Julian Elischer julian at elischer.org
Wed Apr 28 11:26:17 PDT 2004



On Wed, 28 Apr 2004, John Baldwin wrote:

> On Wednesday 28 April 2004 02:26 am, Alex Lyashkov wrote:
> > Hi All
> >
> > how i see many points at kernel work with allproc list direct, but
> > proc.h introduce macros FOREACH_PROC_IN_SYSTEM.
> > This patch clean this places.
> 
> I'd actually rather see the FOREACH_PROC macro removed, I don't think hiding 
> the fact that it's a TAILQ is all that useful.



it makes it possible (well, easier) to do:

FOREACH_PROC_IN_SYSTEM(p) {
	FOREACH_KSEGROUP_IN_PROC(p, kg) {
		FOREACH_THREAD_IN_GROUP(kg.td) {
			something(td, kg);
		}
	}
}

Which is a lot easier to read and understand
than the expanded version. You don't kave to remember the linkage
pointer's names and you can add debugging  to it
and check that the correct loks are held etc.
(the latter being a major reason I did it).



> 
> -- 
> John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
> "Power Users Use the Power to Serve"  =  http://www.FreeBSD.org
> _______________________________________________
> freebsd-current at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe at freebsd.org"
> 



More information about the freebsd-current mailing list