Intel SATA ICH5/5R 6300ESB support patches

Doug Ambrisko ambrisko at
Sun Apr 4 13:21:51 PDT 2004

Poul-Henning Kamp writes:
| In message <200404042002.i34K2nop038808 at>, Doug Ambrisko writes:
| >Søren Schmidt writes:
| >| > I put in a patch for geom for bio_taskqueue_remove.  Since ata code
| >| > schedules bio_task it need to be cancelled when we abort and call
| >| > biodone.  If we don't cancel this task then when the task is 
| >| > run later we get a double free in UMA since we have cleaned up
| >| > twice and called biodone twice for the same request.
| Sos@ forwarded that patch and it won't fly, it has no chance of
| working reliably on multi-cpu machines:
| There is no guarantee that the task is still on the queue by the
| time you try to remove it, and if is not, it is likely to be because
| another CPU is already waiting for a lock in the ata driver in the
| bio_taskqueue handler function, so we have no way to cancel that
| other CPU's activity.
| The correct solution is to not do the biodone when you cancel, but
| let the already scheduled bio_taskqueue event to do so.

Okay, I'll look at the ata code so that it only does it once.


Doug A.

More information about the freebsd-current mailing list