scsi_cd or atapicam crash in current.

[Thomas Quinot]

Le 2003-09-16, Daniel Eischen écrivait :

> I get this even without atapicam in the kernel.  Is trying
> CAMDEBUG and CAM_DEBUG_CDB going to show anything interesting?

No, indeed, probably not. Can you try the following patch:

Index: ata-lowlevel.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-lowlevel.c,v
retrieving revision 1.11
diff -u -r1.11 ata-lowlevel.c
--- ata-lowlevel.c	10 Sep 2003 09:57:16 -0000	1.11
+++ ata-lowlevel.c	16 Sep 2003 15:00:13 -0000
@@ -374,6 +374,11 @@
 
     /* ATAPI PIO commands */
     case ATA_R_ATAPI:
+	if (request->status & (ATA_S_ERROR | ATA_S_DWF)) {
+	    request->error = ATA_IDX_INB(ch, ATA_ERROR);
+	    break;
+	}
+
 	length = ATA_IDX_INB(ch, ATA_CYL_LSB)|(ATA_IDX_INB(ch, ATA_CYL_MSB)<<8);
 
 	switch ((ATA_IDX_INB(ch, ATA_IREASON) & (ATA_I_CMD | ATA_I_IN)) |
@@ -446,8 +451,6 @@
 
 	case ATAPI_P_ABORT:
 	case ATAPI_P_DONE:
-	    if (request->status & (ATA_S_ERROR | ATA_S_DWF))
-		request->error = ATA_IDX_INB(ch, ATA_ERROR);
 	    break;
 
 	default:
-- 
    Thomas.Quinot at Cuivre.FR.EU.ORG
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20030916/2a037255/attachment.bin