FBSD 5.1b2 Inst. Results on Dell i8500

[Bruce Cran]

On Thu, May 22, 2003 at 01:05:42PM +0200, Sebastian Yepes [ESN] wrote:
> I have installed on my Dell Inspiron 5.0R, 5.1b2 & 5-Current ihave found some 
> good stuff on the 5.1b2  and some bad stuff.. her we go
> 
> 
> dmseg -> http://www.x123.info/src/i8500/dmesg.5.1b2
> 
> 
> Good Stuff::
> ---------------------
> Well it look like the Intel ICH4 UDMA100 controller is working now i well make 
> some benchmarks to see if this is true..
> this was not working on the 5.0R
> 
> 
> Bad Stuff::
> ---------------------
> ACPI::	on the console i get a constante flood of this msg 
> 	.....
>  	 ACPI-0293: *** Warning: Buffer created with zero length in AML
>   	      -0166: *** Error: UtAllocate: Attempt to allocate zero bytes
> 	    ACPI-0293: *** Warning: Buffer created with zero length in AML
> 	        -0166: *** Error: UtAllocate: Attempt to allocate zero bytes
> 	    ACPI-0293: *** Warning: Buffer created with zero length in AML
> 	        -0166: *** Error: UtAllocate: Attempt to allocate zero bytes
> 	.....
> 
> In the 5.0R the Battery satus was working ok,
> but now on the 5-Corrent it's not  ;( 

The attached patch fixes the battery status and stops the messages on my 
i8500.  Sleep states S1 and S5 work, as do the lid, power and sleep buttons.

--
Bruce Cran
-------------- next part --------------
--- sys/contrib/dev/acpica/dsmthdat.c Mon May 12 01:44:41 2003
+++ sys/contrib/dev/acpica/dsmthdat.c Wed May 14 16:00:50 2003
@@ -392,8 +393,6 @@
 {
     ACPI_STATUS             Status;
     ACPI_NAMESPACE_NODE     *Node;
-    ACPI_OPERAND_OBJECT     *NewDesc = Object;
-

     ACPI_FUNCTION_TRACE ("DsMethodDataSetValue");

@@ -411,32 +409,14 @@
         return_ACPI_STATUS (Status);
     }

-    /*
-     * If the object has just been created and is not attached to anything,
-     * (the reference count is 1), then we can just store it directly into
-     * the arg/local.  Otherwise, we must copy it.
-     */
-    if (Object->Common.ReferenceCount > 1)
-    {
-        Status = AcpiUtCopyIobjectToIobject (Object, &NewDesc, WalkState);
-        if (ACPI_FAILURE (Status))
-        {
-            return_ACPI_STATUS (Status);
-        }
-
-       ACPI_DEBUG_PRINT ((ACPI_DB_EXEC, "Object Copied %p, new %p\n",
-           Object, NewDesc));
-    }
-    else
-    {
         /* Increment ref count so object can't be deleted while installed */

-        AcpiUtAddReference (NewDesc);
-    }
+   AcpiUtAddReference (Object);

     /* Install the object */

-    Node->Object = NewDesc;
+   Node->Object = Object;
+
     return_ACPI_STATUS (Status);
 }