Missing break in switch in nfsserver code ?

Poul-Henning Kamp phk at phk.freebsd.dk
Wed May 14 12:02:16 PDT 2003


FlexeLint warned me that there was a switch fall-through here.
Can anybody say if this is intentional, or if a break is missing ?

If it is intentional, we should make it with "/* fall through */"

Poul-Henning

Index: nfsserver/nfs_syscalls.c
===================================================================
RCS file: /home/ncvs/src/sys/nfsserver/nfs_syscalls.c,v
retrieving revision 1.87
diff -u -r1.87 nfs_syscalls.c
--- nfsserver/nfs_syscalls.c	2 Mar 2003 16:54:39 -0000	1.87
+++ nfsserver/nfs_syscalls.c	14 May 2003 19:00:36 -0000
@@ -457,6 +457,7 @@
 			nfsrvstats.srvrpccnt[nd->nd_procnum]++;
 			nfsrv_updatecache(nd, TRUE, mreq);
 			nd->nd_mrep = NULL;
+			/* XXX: missing break ?? */
 		    case RC_REPLY:
 			siz = m_length(mreq, NULL);
 			if (siz <= 0 || siz > NFS_MAXPACKET) {
-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.


More information about the freebsd-current mailing list