cvs commit: src/sys/dev/pci pci.c (fwd)

[John Baldwin]

On 08-Jun-2003 Doug Barton wrote:
> This set of commits seems to have fixed a perennial problem I've had with
> my laptop and acpi. Previously, about every 3rd or 4th reboot the pci bus
> would fail to initialize, the major symptom of which was that the xl card
> wouldn't set up, and I'd have to reboot again. Disabling acpi eliminated
> the problem (or the symptom, depending on how you look at it).
> 
> With a kernel built from the latest sources, the pci bus and xl are happy,
> but I'm getting flooded with the following:
> 
> ACPI-0340: *** Error: Could not release ACPI Global Lock, AE_BAD_PARAMETER
> 
> This is on an older thinkpad A21e. It has run -current fine for over a
> year, modulo this pci problem, and general thinkpad <> acpi unhappiness.
> Any other details needed, just ask.

This message is due to a bug in ACPICA.  Patch looks like this:

Index: hwregs.c
===================================================================
RCS file: /usr/cvs/src/sys/contrib/dev/acpica/hwregs.c,v
retrieving revision 1.1.1.16
diff -u -r1.1.1.16 hwregs.c
--- hwregs.c    3 May 2003 17:16:40 -0000       1.1.1.16
+++ hwregs.c    7 Jun 2003 14:23:57 -0000
@@ -510,8 +510,8 @@
         ACPI_REGISTER_INSERT_VALUE (RegisterValue, BitRegInfo->BitPosition,
                 BitRegInfo->AccessBitMask, Value);
 
-        Status = AcpiHwRegisterWrite (ACPI_MTX_DO_NOT_LOCK, RegisterId,
-                (UINT16) RegisterValue);
+        Status = AcpiHwRegisterWrite (ACPI_MTX_DO_NOT_LOCK,
+                       ACPI_REGISTER_PM1_CONTROL, (UINT16) RegisterValue);
         break;

Glad to hear your other problems have been solved. :)

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/