HEADSUP: UMA not reentrant / possible memory leak
bmilekic at technokratis.com
Wed Jul 30 06:07:15 PDT 2003
On Tue, Jul 29, 2003 at 11:42:51PM -0400, Jeff Roberson wrote:
> On Wed, 30 Jul 2003 Tor.Egge at cvsup.no.freebsd.org wrote:
> > > The indication of this is that the g_bio zone does not return to
> > > zero USED as it should.
> > It looks like z->uz_cachefree is slightly out of date (updated in
> > zone_timout() every 20th second) and often too low (not taking the
> > z->uz_full_bucket list into account).
> > The enclosed patch recalculates the number of free elements on the
> > buckets instead of using z->uz_cachefree.
> I definitely like this patch. If it works would you please commit it?
> There are other issues for sure though. UMA can leak pages from zones
> when they are destroyed. I'm going to look into this asap.
Tor's patch does address the problem of having to account for the
buckets in the zone as well (besides for just the pcpu cache buckets).
So if it does get committed, can the calculation of uz_cachefree from
the timer routine be axed in the same change, as it is no longer
Bosko Milekic * bmilekic at technokratis.com * bmilekic at FreeBSD.org
TECHNOkRATIS Consulting Services * http://www.technokratis.com/
More information about the freebsd-current