Fix for rman [was: Re: [-CURRENT tinderbox] ...]

[Marcel Moolenaar]

On Wed, Jul 16, 2003 at 01:59:44AM -0700, Kris Kennaway wrote:
> On Wed, Jul 16, 2003 at 12:43:37AM -0700, Marcel Moolenaar wrote:
> > On Tue, Jul 15, 2003 at 10:16:01PM -0700, Kris Kennaway wrote:
> > > > 
> > > > malloc, you say? I have build failures in XFree4-clients because
> > > > rman coredumps and I have a backtrace full of free() frames...
> > > > 
> > > > Coincidence?
> > > 
> > > Some of the XFree86 utilities contain malloc bugs..rman in particular
> > > has been dumping core on certain ports for a couple of years.  I tried
> > > to track it down once but couldn't find it.
> > 
> > [cc anholt@]
> > 
> > The attached patch fixes rman. The faulting case is "\\\0". The '\0'
> > was handled in the default case for escaped characters, which also
> > incremented the pointer p beyond the terminating '\0'. 
> > 
> > Oh: this goes to devel/imake-4 of course.
> > 
> > -- 
> >  Marcel Moolenaar	  USPA: A-39004		 marcel at xcllnt.net
> 
> The print/gv port has patch-ad to work around another rman bug.  This
> bug is only exposed by malloc debugging.

Probably a different bug. The ^G is assumed to be a delimiter. The
code will look for the closing delimiter, but will not find one.
This too can result in runnaway pointers. I haven't analyzed the
code that closely though.

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel at xcllnt.net