PATCH - updated EC driver

[John Baldwin]

On 09-Jul-2003 Nate Lawson wrote:
> On Wed, 9 Jul 2003, John Baldwin wrote:
>> On 09-Jul-2003 Nate Lawson wrote:
>> >    http://root.org/~nate/freebsd/ec-new.diff
>>
>> Not as broken as the last patch, but still broken for me:
>>
>>     ACPI-0432: *** Error: Handler for [EmbeddedControl] returned AE_NO_HARDWARE_RESPONSE
>>     ACPI-1287: *** Error: Method execution failed [\\_SB_.PCI0.PX41.SECN.BEXT] (Node
>>     0xc3342260),
>> AE_NO_HARDWARE_RESPONSE
>>     ACPI-1287: *** Error: Method execution failed [\\_SB_.PCI0.PX41.SECN.MAST._STA] (Node
>> 0xc3342320), AE_NO_HARDWARE_RESPONSE
> 
> Thanks for testing.
> 
> Try changing the 1000 in line 658 to 10000.  Your EC seems to take more
> than 1 ms to respond.  The old behavior was 10 ms which I thought was too
> long but apparently your system requires this.

Yes, this gets rid of the message at boot times.  I do get some of these messages
while the system is running, but I used to receive those erros before.  The only
difference is that now the error code is AE_NO_HARDWARE_RESPONSE rather than
AE_ERROR.

> BTW, what are the guidelines for DELAY vs. msleep?  I'm holding a mutex
> for the local EC for up to 10 ms in that case, in increments of DELAY(10).
> I would think that somewhere around 1 ms, the delay needs to become an
> msleep so other device interrupts can occur (i.e. EcGpeHandler).  I'm
> thinking about having the loop up to 1 ms be based on DELAY, and then 9
> calls to msleep(..., 1) for the really slow devices.  Let me know what you
> think is best.

That sounds fine to me.  10ms would be a very long time to hold a mutex.

> -Nate

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/