[ATAng?] ad1 disappeared again

[Chris Faulhaber]

On Wed, Dec 03, 2003 at 09:55:56AM +0100, Soren Schmidt wrote:
> It seems Chris Faulhaber wrote:
> > I have been seeing the same issue since August with a different,
> > but similiar, set of drives:
> > 
> > ad0: 57241MB <ST360015A> [116301/16/63] at ata0-master UDMA100
> > ad1: 57241MB <ST360015A> [116301/16/63] at ata0-slave UDMA100
> > 
> > Under -CURRENT only the first drive is seen; RELENG_4 still works
> > fine.
> 
> Could you try this patch and get back to me with the result please:
> 

Works for me:

GEOM: create disk ad0 dp=0xc6972c60
ad0: 57241MB <ST360015A> [116301/16/63] at ata0-master UDMA100
GEOM: create disk ad1 dp=0xc6972b60
ad1: 57241MB <ST360015A> [116301/16/63] at ata0-slave UDMA100

> Index: ata-lowlevel.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/ata/ata-lowlevel.c,v
> retrieving revision 1.23
> diff -u -r1.23 ata-lowlevel.c
> --- ata-lowlevel.c      2 Nov 2003 22:04:53 -0000       1.23
> +++ ata-lowlevel.c      3 Dec 2003 07:50:44 -0000
> @@ -575,7 +575,7 @@
>                 }
>             }
>         }
> -       if (stat1 & ATA_S_BUSY) {
> +       if (!((mask == 0x03) && (stat0 & ATA_S_BUSY)) && (stat1 & ATA_S_BUSY)) {
>             ATA_IDX_OUTB(ch, ATA_DRIVE, ATA_D_IBM | ATA_SLAVE);
>             DELAY(10);
> 
> -S?ren
>                        .. but it works under windows!!
> 

-- 
Chris D. Faulhaber - jedgar at fxp.org - jedgar at FreeBSD.org
--------------------------------------------------------
FreeBSD: The Power To Serve   -   http://www.FreeBSD.org