5.2-BETA dsp.c duplicate lock

[Jesse Guardiani]

Maxime Henrion wrote:

> Mathew Kanner wrote:
> [patch ripped]
>> 
>> Maxime,
>> I think it would be better to isolate the changes (DUP_OK flag
>> and lock creation) to just the channel code, no need to touch every
>> driver.
> 
> Yes, but to do this I'd need either to make the channel code use
> mtx_init() directly, which would defeat the purpose of the USING_MUTEX
> define, or to completely unifdef -U it.  Since I had no idea if this code
> was actually used or not, I went the safe way and just changed the
> snd_mtxcreate() wrapper interface to accept mutex options.  For what it's
> worth, there is at least one direct invokation of mtx_init() in the sound
> drivers, so it seems this define is actually already broken.
> 
> This needs to be sorted out before committing this patch if we need to,
> but for now, I just wanted to see if using MTX_DUPOK solved the problem or
> not.

I'll try to test later today. Thanks!

-- 
Jesse Guardiani, Systems Administrator
WingNET Internet Services,
P.O. Box 2605 // Cleveland, TN 37320-2605
423-559-LINK (v)  423-559-5145 (f)
http://www.wingnet.net