IBM T30 bluetooth - success (fwd)

[Tobias Roth]

eh? i silently assumed that it already was commited! i used bluetooth
on my T30 on -current which is maybe three weeks old and it works!

and to make this very clear, it did NOT work on a -current from around
the time when i sent that email below. the patch fixed it back then,
nothing else did.

so, now i am confused...


On Mon, Aug 25, 2003 at 01:24:20PM -0700, Lee Damon wrote:
> Does anyone have an estimate of when this patch will be checked in?
> 
> Please?
> 
> thanks,
> nomad
> 
> ------- Forwarded Messages
> 
> Date: Mon, 16 Jun 2003 23:37:38 +0200
> From: Tobias Roth <roth at iam.unibe.ch>
> To: Lee Damon <nomad at castle.org>
> Subject: Re: IBM T30 bluetooth - success
> Message-ID: <20030616213737.GB3469 at speedy.unibe.ch>
> References: <200306162122.h5GLM2wJ032890 at castle.org>
> 
> 
> --PNTmBPCT7hxwcZjr
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> 
> On Mon, Jun 16, 2003 at 02:22:02PM -0700, Lee Damon wrote:
> > What did you do?
> 
> in short, whining to some people about usb being broken until
> someone (Bernd Walter) came up with a patch :-)
> 
> Other than that, I just followed Pavs tutorials at
> 
> http://www.oook.cz/bsd
> 
> good luck, t.
> 
> --PNTmBPCT7hxwcZjr
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: attachment; filename="usb_working.diff"
> 
> Index: usb_subr.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/usb/usb_subr.c,v
> retrieving revision 1.54
> diff -u -r1.54 usb_subr.c
> --- usb_subr.c	14 Jan 2003 23:07:43 -0000	1.54
> +++ usb_subr.c	14 Jun 2003 16:01:38 -0000
> @@ -964,6 +964,7 @@
>  	usbd_device_handle dev;
>  	struct usbd_device *hub;
>  	usb_device_descriptor_t *dd;
> +	usb_port_status_t ps;
>  	usbd_status err;
>  	int addr;
>  	int i;
> @@ -1020,12 +1021,14 @@
>  	up->device = dev;
>  	dd = &dev->ddesc;
>  	/* Try a few times in case the device is slow (i.e. outside specs.) */
> -	for (i = 0; i < 3; i++) {
> +	for (i = 0; i < 15; i++) {
>  		/* Get the first 8 bytes of the device descriptor. */
>  		err = usbd_get_desc(dev, UDESC_DEVICE, 0, USB_MAX_IPACKET, dd);
>  		if (!err)
>  			break;
>  		usbd_delay_ms(dev, 200);
> +		if ((i & 3) == 3)
> +			usbd_reset_port(up->parent, port, &ps);
>  	}
>  	if (err) {
>  		DPRINTFN(-1, ("usbd_new_device: addr=%d, getting first desc "
> 
> --PNTmBPCT7hxwcZjr--
> 
> ------- Message 2
> 
> Date: Tue, 17 Jun 2003 07:07:25 +0200
> From: Bernd Walter <ticso at cicely12.cicely.de>
> To: Lee Damon <nomad at castle.org>
> Cc: freebsd-current at freebsd.org
> Subject: Re: IBM T30 bluetooth - success
> Message-ID: <20030617050724.GC596 at cicely12.cicely.de>
> 
> On Mon, Jun 16, 2003 at 04:31:25PM -0700, Lee Damon wrote:
> > I can second that success.  Any chance of getting this patch checked in?
> 
> I just wait on a review.
> 
> - -- 
> B.Walter                   BWCT                http://www.bwct.de
> ticso at bwct.de                                  info at bwct.de
> 
> 
> ------- End of Forwarded Messages