Warning with loader Makefile?

[Ruslan Ermilov]

On Fri, Aug 08, 2003 at 11:25:49AM +1200, Andrew Turner wrote:
[...]
> I found this patch worked by removing the secound ${PROG} target if 
> there was already one there.
> 
> --- /usr/src/share/mk/bsd.prog.mk	Mon Jun 30 06:16:26 2003
> +++ /usr/share/mk/bsd.prog.mk	Mon Aug  4 17:54:22 2003
> @@ -31,11 +31,13 @@
>  
>  OBJS+=  ${SRCS:N*.h:R:S/$/.o/g}
>  
> +.if !target(${PROG})
>  ${PROG}: ${OBJS}
>  .if defined(PROG_CXX)
>  	${CXX} ${CXXFLAGS} ${LDFLAGS} -o ${.TARGET} ${OBJS} ${LDADD}
>  .else
>  	${CC} ${CFLAGS} ${LDFLAGS} -o ${.TARGET} ${OBJS} ${LDADD}
> +.endif
>  .endif
>  
>  .else !defined(SRCS)

No, thanks.  If a makefile has a

${PROG}: foo

line, just to add an additional dependency, this patch will break
building the ${PROG}.


Cheers,
-- 
Ruslan Ermilov		Sysadmin and DBA,
ru at sunbay.com		Sunbay Software Ltd,
ru at FreeBSD.org		FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20030808/0808591d/attachment.bin