[Bug 255523] vn_generic_copy_file_range copies holes to EOF slowly

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun May 2 01:56:04 UTC 2021


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255523

Rick Macklem <rmacklem at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224599|0                           |1
        is obsolete|                            |
           Assignee|bugs at FreeBSD.org            |rmacklem at FreeBSD.org

--- Comment #5 from Rick Macklem <rmacklem at FreeBSD.org> ---
Created attachment 224603
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=224603&action=edit
add support for a hole to eof to vn_generic_copy_range()

Update patch as suggested by asomers at .
Moving the VOP_GETATTR() is actually
a fix, since "goto out;" assumes an
unlocked invp. It also is slightly optimized,
since the inva are only needed if holein > 0.

I moved the initialization of holetoeof to
above the loop, since it easier to spot there
(and I thoght style(9) frowned on initializations
 in declarations).

No semntics change unless VOP_GETATTR() fails
for some reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list