[Bug 254610] tcp_bbr broken after 69a34e8d0235c0304a28bf8ab076b931aa61835f

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254610

            Bug ID: 254610
           Summary: tcp_bbr broken after
                    69a34e8d0235c0304a28bf8ab076b931aa61835f
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: bugs at FreeBSD.org
          Reporter: delphij at FreeBSD.org

After
https://cgit.freebsd.org/src/commit/?id=69a34e8d0235c0304a28bf8ab076b931aa61835f
, a kernel configured with tcp_bbr would panic on start when a network facing
service starts:

panic: mtx_lock() of spin mutex socket @ /usr/src/sys/kern/uipc_socket.c:3615
cpuid = 3
time = 1616820332
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe01f70315f0
vpanic() at vpanic+0x181/frame 0xfffffe01f7031640
panic() at panic+0x43/frame 0xfffffe01f70316a0
__mtx_lock_flags() at __mtx_lock_flags+0x13b/frame 0xfffffe01f70316f0
soo_kqfilter() at soo_kqfilter+0x93/frame 0xfffffe01f7031730
kqueue_register() at kqueue_register+0x680/frame 0xfffffe01f70317c0
kqueue_kevent() at kqueue_kevent+0x103/frame 0xfffffe01f7031a90
kern_kevent_fp() at kern_kevent_fp+0x95/frame 0xfffffe01f7031ae0
kern_kevent() at kern_kevent+0x80/frame 0xfffffe01f7031b40
kern_kevent_generic() at kern_kevent_generic+0x70/frame 0xfffffe01f7031ba0
sys_kevent() at sys_kevent+0x61/frame 0xfffffe01f7031c00
amd64_syscall() at amd64_syscall+0x12e/frame 0xfffffe01f7031d30
fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe01f7031d30
--- syscall (560, FreeBSD ELF64, sys_kevent), rip = 0x800c7464a, rsp =
0x7fffdf9ead98, rbp = 0x7fffdf9eade0 ---
.

With the revision reverted locally (commits:
e13e4fa6c4eba72de5c4685942de5dbe8f43db73,
0a4f851074a3ca74cd4859c20e7d9807b2aeca65,
ab4fad4be14462e347ed24ee3663a18eacfb138e and
69a34e8d0235c0304a28bf8ab076b931aa61835f), the issue is gone.

This is not reproducible if tcp_bbr is not loaded and
net.inet.tcp.functions_default=bbr removed from /etc/sysctl.conf, with or
without these revisions reverted.

-- 
You are receiving this mail because:
You are the assignee for the bug.