[Bug 253915] pchtherm0: Sensor enable failed

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253915

--- Comment #1 from michal at microwave.sk ---
I managed to fix this first issue with this simple patch:

# git diff
diff --git a/sys/dev/intel/pchtherm.c b/sys/dev/intel/pchtherm.c
index 13f0abc54b6..4a9edc2da28 100644
--- a/sys/dev/intel/pchtherm.c
+++ b/sys/dev/intel/pchtherm.c
@@ -163,7 +163,7 @@ static int pchtherm_attach(device_t dev)
                        bus_write_1(sc->tbar, PCHTHERM_REG_TSEL,
                                    PCHTHERM_GEN_ENABLE);
                        sc->enable = bus_read_1(sc->tbar, PCHTHERM_REG_TSEL);
-                       if (!(sc->enable & PCHTHERM_REG_TSEL)){
+                       if (!(sc->enable & PCHTHERM_GEN_ENABLE)) {
                                device_printf(dev, "Sensor enable failed\n");
                                return 0;
                        }

Now pchtherm gets enabled as it should:

# dmesg | grep pchtherm
pchtherm0: <Haswell Thermal Subsystem> mem 0x383ffff10000-0x383ffff10fff irq 18
at device 31.6 on pci1
pchtherm0: Enabling Sensor

But reported values are strange:

# sysctl dev.pchtherm
dev.pchtherm.0.ctt: 130.0C
dev.pchtherm.0.talv: -50.0C
dev.pchtherm.0.tahv: -50.0C
dev.pchtherm.0.temperature: 67.5C
dev.pchtherm.0.pch_hot_level: -50.0C
dev.pchtherm.0.t2temp: -50.0C
dev.pchtherm.0.t1temp: -50.0C
dev.pchtherm.0.t0temp: -50.0C
dev.pchtherm.0.pmtime: 1
dev.pchtherm.0.pmtemp: -50.0C
dev.pchtherm.0.%parent: pci1
dev.pchtherm.0.%pnpinfo: vendor=0x8086 device=0x8c24 subvendor=0x15d9
subdevice=0x086d class=0x118000
dev.pchtherm.0.%location: slot=31 function=6 dbsf=pci0:0:31:6
handle=\_SB_.PCI0.TERM
dev.pchtherm.0.%driver: pchtherm
dev.pchtherm.0.%desc: Haswell Thermal Subsystem
dev.pchtherm.%parent: 

regards,
michal

-- 
You are receiving this mail because:
You are the assignee for the bug.