[Bug 244470] /sbin/dump crashes on larger filesystem

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244470

bitbucket63-it at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bitbucket63-it at yahoo.com

--- Comment #7 from bitbucket63-it at yahoo.com ---
This happened to me as well after I added a bunch of large files.

I went searching for answers and eventually noticed that the assertion in
question in traverse.c was different than the other assertions implemented as
part of bug #228807, comment #5 implemented in base r334969. Specifically it
tested for "<" TP_NINDIR instead of "<=" TP_NINDIR where other asserts
implemented a <= test.

On my file system "spcl.c_count + blks" reached exactly 512 at the point of
failure, which is the value of TP_NINDIR. Perhaps the assert should have tested
for <= rather than <. 

I changed the line in traverse.c and now dump seems to be working again on the
file system with lots of indirect inodes. I've uploaded a diff.

FYI, I'm the equivalent of a passenger trying to land the plane after the
flight crew passes out, so YMMV.

-- 
You are receiving this mail because:
You are the assignee for the bug.