[Bug 255309] ice(4) driver doesn't use RSS option correctly

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255309

            Bug ID: 255309
           Summary: ice(4) driver doesn't use RSS option correctly
           Product: Base System
           Version: 12.2-RELEASE
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: bugs at FreeBSD.org
          Reporter: brian90013 at gmail.com

Created attachment 224335
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=224335&action=edit
patch to properly support rss option

Hello,

I am testing the Intel E810 NIC using the ice driver on both FreeBSD-12.2 and
FreeBSD-13.0. During testing, I enabled the RSS kernel configuration option so
the driver would use the system-wide standard RSS key instead of the custom ice
key. I was surprised to see even after rebooting, the driver was still using
the ice key.

My debugging led me to ice_lib.h where ice_rss.h is included. However, I don't
believe there is a prior include of ice_opts.h, so when ice_rss.h is parsed,
RSS is not defined causing ice-specific definitions to be used. I added
ice_opts.h to the include list above ice_rss.h and re-compiled.

I hit a second problem within ice_rss.h where ICE_DEFAULT_RSS_HASH_CONFIG is
only defined inside the !RSS block. I believe this is an oversight, probably
hidden by the previous bug. That variable is used in ice_lib.c so it cannot
depend on the state of the RSS option. Therefore, I moved the definition
outside of the RSS/!RSS blocks.

With these two changes, in the included patch file, I observed the ice driver
using RSS settings from the kernel, not ice-specific values. Looking at the
FreeBSD-13.0 and HEAD branches, it looks like the same problems are present.

-- 
You are receiving this mail because:
You are the assignee for the bug.