[Bug 255202] drawer.lua: brand positioning not working

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255202

            Bug ID: 255202
           Summary: drawer.lua: brand positioning not working
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: misc
          Assignee: bugs at FreeBSD.org
          Reporter: jlduran at gmail.com
                CC: kevans at freebsd.org, tsoome at freebsd.org

Created attachment 224233
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=224233&action=edit
Screenshot with spindle artifact

drawer.lua ignores the values in `loader_brand_x` and `loader_brand_y`.

I have attached a patch that *fixes* it, but I would like to request, if
possible, some reviewing.

I have also attached a screenshot, taken with the patch applied, however
there's the spindle? artifact hanging around, and being shifted by the
offsetting of the brand (indicated by the red arrow). I don't know how to
address this.

This can be replicated by creating two files:

/boot/loader.conf.d/bootloader.conf:
loader_logo="none"
loader_brand="nakatomi"
loader_brand_x="15"

/boot/lua/gfx-nakatomi.lua:
return {
        brand = {
                image = "/boot/images/freebsd-logo-rev.png"
        }
}

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.