[Bug 246614] certctl(8) silently overwrites certs with same subjects

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Sep 9 09:08:42 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246614

--- Comment #15 from commit-hook at FreeBSD.org ---
A commit references this bug:

Author: kevans
Date: Wed Sep  9 09:08:09 UTC 2020
New revision: 365500
URL: https://svnweb.freebsd.org/changeset/base/365500

Log:
  certctl: fix hashed link generation with duplicate subjects

  Currently, certctl rehash will just keep clobbering .0 rather than
  incrementing the suffix upon encountering a duplicate. Do this, and do it
  for blacklisted certs as well.

  This also improves the situation with the blacklist to be a little less
  flakey, comparing cert fingerprints for all certs with a matching subject
  hash in the blacklist to determine if the cert we're looking at can be
  installed.

  Future work needs to completely revamp the blacklist to align more with how
  it's described in PR 246614. In particular, /etc/ssl/blacklisted should go
  away to avoid potential confusion -- OpenSSL will not read it, it's
  basically certctl internal.

  PR:           246614
  Reviewed by:  Michael Osipov <michael.osipov siemens com>
  Tested by:    Michael Osipov
  With suggestions from:        Michael Osipov
  MFC after:    1 week
  Differential Revision:        https://reviews.freebsd.org/D26167

Changes:
  head/usr.sbin/certctl/certctl.sh

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-bugs mailing list