[Bug 249050] if_qlxgb mtu not initialized bug causing wrong pkt 0x62 dump start

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249050

            Bug ID: 249050
           Summary: if_qlxgb  mtu not initialized bug causing wrong pkt
                    0x62 dump start
           Product: Base System
           Version: 12.1-STABLE
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: kern
          Assignee: bugs at FreeBSD.org
          Reporter: novacrash_ at hotmail.com

Created attachment 217690
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=217690&action=edit
Fix that mtu not initialized bug

ql1: qla_pci_attach: firmware[4.20.1.1429931003]
ql1: Ethernet address: 8c:dc:d4:59:c1:6c
ql1: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS)
ql1: link state changed to UP
ql1: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start
ql1: 0x00000000: ff ff ff ff ff ff 8c dc d4 59 c1 6c 08 06 00 01
ql1: 0x00000010: 08 00 06 04 00 01 8c dc d4 59 c1 6c c0 a8 c8 05
ql1: 0x00000020: 00 00 00 00 00 00 c0 a8 c8 05
ql1: qla_dump_buf8: qla_hw_send: wrong pkt dump end
ql1: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS)
ql1: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start
ql1: 0x00000000: ff ff ff ff ff ff 8c dc d4 59 c1 6c 08 06 00 01
ql1: 0x00000010: 08 00 06 04 00 01 8c dc d4 59 c1 6c c0 a8 c8 05
ql1: 0x00000020: 00 00 00 00 00 00 c0 a8 c8 0a
ql1: qla_dump_buf8: qla_hw_send: wrong pkt dump end
ql1: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS)
ql1: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start
ql1: 0x00000000: ff ff ff ff ff ff 8c dc d4 59 c1 6c 08 06 00 01
ql1: 0x00000010: 08 00 06 04 00 01 8c dc d4 59 c1 6c c0 a8 c8 05
ql1: 0x00000020: 00 00 00 00 00 00 c0 a8 c8 0a
ql1: qla_dump_buf8: qla_hw_send: wrong pkt dump end
ql1: qla_hw_send: (nsegs[1, 98, 0x0] > Q8_TX_MAX_SEGMENTS)
ql1: qla_dump_buf8: qla_hw_send: wrong pkt 0x62 dump start
ql1: 0x00000000: 90 e2 ba eb 01 68 8c dc d4 59 c1 6c 08 00 45 00
ql1: 0x00000010: 00 54 37 be 00 00 40 01 31 8a c0 a8 c8 05 c0 a8
ql1: 0x00000020: c8 0a 08 00 22 30 22 19 00 01 5a 94 07 ae 00 00
ql1: 0x00000030: 66 70 08 09 0a 0b 0c 0d 0e 0f 10 11 12 13 14 15
ql1: 0x00000040: 16 17 18 19 1a 1b 1c 1d 1e 1f 20 21 22 23 24 25
ql1: 0x00000050: 26 27 28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 34 35
ql1: 0x00000060: 36 37
ql1: qla_dump_buf8: qla_hw_send: wrong pkt dump end

MTU need to be initialized before qla_os:685
ha->max_frame_size = ifp->if_mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;

Otherwise packet is always flagged as too big in qla_hw.c:1003
if ((mp->m_pkthdr.len > ha->max_frame_size)||(nsegs > Q8_TX_MAX_SEGMENTS)) {

I also moved qla_os:694
ifp->if_capabilities = IFCAP_LINKSTATE;

Before qla_os:687
ether_ifattach(ifp, qla_get_mac_addr(ha));

Like in qlxgbe/ql_os:877 because I had trouble doing ifconfig ql0 up for
bridge.

-- 
You are receiving this mail because:
You are the assignee for the bug.