[Bug 244967] pw: userdel will delete a home directory not owned by the user (if it is empty)

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Mar 22 04:21:13 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244967

--- Comment #2 from Eric Hanneken <eric at erichanneken.com> ---
Comment on attachment 212604
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=212604
Patch to pw(8)

Index: usr.sbin/pw/rm_r.c
===================================================================
--- usr.sbin/pw/rm_r.c  (revision 359195)
+++ usr.sbin/pw/rm_r.c  (working copy)
@@ -71,5 +71,8 @@
        closedir(d);
        if (fstatat(rootfd, path, &st, AT_SYMLINK_NOFOLLOW) != 0)
                return;
-       unlinkat(rootfd, path, S_ISDIR(st.st_mode) ? AT_REMOVEDIR : 0);
+       if (S_ISLNK(st.st_mode))
+               unlinkat(rootfd, path, 0);
+       else if (st.st_uid == uid)
+               unlinkat(rootfd, path, AT_REMOVEDIR);
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list