[Bug 129965] [patch] ps(1): ps -lH doesn't show the proper CPU#

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Jun 27 19:09:49 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=129965

--- Comment #6 from commit-hook at freebsd.org ---
A commit references this bug:

Author: pstef
Date: Sat Jun 27 19:09:34 UTC 2020
New revision: 362705
URL: https://svnweb.freebsd.org/changeset/base/362705

Log:
  ps(1): reuse keyword "cpu" to show CPU number

  This flag will now show the processor number on which a process is running.

  This change was inspired by PR129965. Initially I didn't think that the
  patch attached to it was correct -- it sacrificed ki_estcpu use in "cpu"
  for ki_lastcpu and I thought that the old functionality should be kept and
  the new (cpu#) one added to it. But I've since discovered that ki_estcpu is
  sched_4bsd-specific. What's worse, it represents the same thing as
  ki_pctcpu, except ki_pctcpu is universal -- so "%cpu" has been using it
  successfully. Therefore, I've decided to replace information based on
  ki_estcpu with information based on ki_oncpu/ki_lastcpu.

  Key parts of the code and manual changes were borrowed from top(1).

  PR:           129965
  Reported by:  Nikola Kne?evi?
  MFC after:    1 week
  Differential Revision:        https://reviews.freebsd.org/D25377

Changes:
  head/bin/ps/extern.h
  head/bin/ps/keyword.c
  head/bin/ps/print.c
  head/bin/ps/ps.1
  head/bin/ps/ps.c

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list