[Bug 247131] vm: Fix typos

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Jun 10 16:04:21 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247131

--- Comment #2 from Mark Johnston <markj at FreeBSD.org> ---
I'm not a big fan of this patch: the typos don't really hurt readability, and
fixing them will pollute the commit history, making it harder to find the
original commit that added a given line.

The changes are also not really consistent.  For example:
- One change to swap_pager.c changes "SWAP" to "OBJT_SWAP", but leaves
"DEFAULT" as-is.
- One hunk changes one instance "type-stability" to "type stability" (why?),
but that term appears in multiple places in sys/vm.
- A couple of changes add a period to the end of a sentence, but leave the
sentence uncapitalized.

If we are going to churn the sources, the diff should fix as many problems as
possible while not introducing inconsistencies.  In general I'd prefer to see
patches that rewrite comments to make them more useful, fixing typos as a side
effect, or simply deleting self-evident comments like /* remove kernel mappings
*/ followed by a pmap_qremove() call.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list