[Bug 248213] TCP BBR - Two FINs with same seq number are seen in simultaneous close

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248213

--- Comment #2 from Hitesh <maisheri.hitesh at gmail.com> ---
The following block  of code is what causing the non-conformance with RFC.
Also, the validation for FIN flag here is redundant.

                        if (flags & TH_FIN && tp->t_flags & TF_SENTFIN) {
                                /*
                                 * If we sent the fin already its 1 minus
                                 * snd_max
                                 */
                                th->th_seq = (htonl(tp->snd_max - 1));
                                bbr_seq = (tp->snd_max - 1);
                        } else {
                                /* First time FIN use snd_max */
                                th->th_seq = htonl(tp->snd_max);
                                bbr_seq = tp->snd_max;
                        }

-- 
You are receiving this mail because:
You are the assignee for the bug.