[Bug 242828] diff -rq still does full file comparison

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Jan 8 11:47:09 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242828

--- Comment #2 from fehmi noyan isi <fnoyanisi at yahoo.com> ---
I think adding one _if_ check to the case where the files differ would be
sufficient;

        switch (files_differ(f1, f2, flags)) {
        case 0:
                goto closem;
        case 1:
                /* if brief output is needed, just return to the caller */
                if (diff_format == D_BRIEF) {
                        rval = D_DIFFER;
                        goto closem;
                }
                break;
        default:
                /* error */
                status |= 2;
                goto closem;
        }

with this change, when -q or --brief is used, diff(1) will just print a message
without doing any further work

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list