[Bug 251868] Add tcgetwinsize() and tcsetwinsize() to termios.h

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251868

--- Comment #7 from SOUMENDRA GANGULY <0.gangzta at gmail.com> ---
Sir, I have created a phabricator account. Can you please approve it? The email
address is the same as that of this Bugzilla account.

I have made an observation. Both the NetBSD and the OpenBSD versions of
termios.h only have sys/ttydefaults.h in the last block after the #endif /*
!_TERMIOS_H_ */:

https://github.com/NetBSD/src/blob/trunk/sys/sys/termios.h
https://github.com/openbsd/src/blob/master/sys/sys/termios.h

glibc does something similar:
https://github.com/bminor/glibc/blob/master/termios/termios.h although their
sys/ttydefaults.h is being included in the protected block.

FreeBSD's termios.h was changed from
https://svnweb.freebsd.org/base/head/include/termios.h?revision=191882&view=markup
to
https://svnweb.freebsd.org/base/head/include/termios.h?revision=199898&view=markup
when ttycom.h suddenly got moved to the last block; there is no explanation in
the SVN "commit message" as to why that was done. I suspect that it was a
mistake.

If you think that my claim is correct, then I will replace the #include
<sys/ioctl.h> in my diff with a #include <sys/ttycom.h> and remove the #include
<sys/ttycom.h> from the final block; sys/ttycom.h contains the definition of
struct winsize needed for tcgetwinsize() and tcsetwinsize(). Basically, then it
will look like the NetBSD header:
https://github.com/NetBSD/src/blob/trunk/sys/sys/termios.h

Thank you for your time.

-- 
You are receiving this mail because:
You are the assignee for the bug.