[Bug 251483] after upgrading from 12.1 to 12.2 the mfi driver crashes during boot

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251483

--- Comment #4 from cstamas+fbsdbz at digitus.itk.ppke.hu ---
I reverted the change and the kernel boots up properly now:

root at backup20vh:/usr/src/sys # svnlite log | head -2
------------------------------------------------------------------------
r368402 | kib | 2020-12-07 01:05:39 +0000 (Mon, 07 Dec 2020) | 3 lines
root at backup20vh:/usr/src/sys # svnlite status
M       dev/mfi/mfi_tbolt.c
root at backup20vh:/usr/src/sys # svnlite diff
Index: dev/mfi/mfi_tbolt.c
===================================================================
--- dev/mfi/mfi_tbolt.c (revision 368414)
+++ dev/mfi/mfi_tbolt.c (working copy)
@@ -1109,7 +1109,7 @@

        if (hdr->cmd == MFI_CMD_PD_SCSI_IO) {
                /* check for inquiry commands coming from CLI */
-               if (cdb[0] != 0x28 && cdb[0] != 0x2A) {
+               if (cdb[0] != 0x28 || cdb[0] != 0x2A) {
                        if ((req_desc = mfi_tbolt_build_mpt_cmd(sc, cm)) ==
                            NULL) {
                                device_printf(sc->mfi_dev, "Mapping from MFI "
root at backup20vh:/usr/src/sys # uname -a
FreeBSD backup20vh.removed-domain 12.2-STABLE FreeBSD 12.2-STABLE #1 r368414M:
Mon Dec  7 17:35:28 UTC 2020    
cstamas at backup20vh.removed-domain:/usr/obj/usr/src/amd64.amd64/sys/GENERIC 
amd64

I even ran zpool scrub and all seems fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.