[Bug 244640] [Patch][Lua loader] Implement missing "read-conf" 4th command
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Wed Apr 29 19:16:07 UTC 2020
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244640
--- Comment #8 from Olivier Certner <olivier.freebsd at free.fr> ---
(In reply to Kyle Evans from comment #7)
Yes, I overlooked 360423, thinking it was wrong (but only the added comment is
;-)). So you're right, the original problem is fixed.
Still, the proposed patch applies POLA for "loader_conf_files", which is a
priori a variable like the others, in addition to its special meaning when
loading, by keeping the latest value it was set at in between loads and at the
end. I have no use for this myself, and a priori cannot think of useful
consequences of that. But still, I think that if "loader_conf_files" can be
clobbered by the loading process (the current state), this should be mentioned
in the documentation for this variable ("loader_conf_files").
Also, I feel that readConf is a more to the point interface for the existing
code, but it may be a matter of taste, and you might have other usage plans
that contradict this. Anyway, it's up to you since you maintain this code.
Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the freebsd-bugs
mailing list