[Bug 240947] Hours calculation in blacklistctl dump output incorrect

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Sep 30 19:05:22 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240947

            Bug ID: 240947
           Summary: Hours calculation in blacklistctl dump output
                    incorrect
           Product: Base System
           Version: 11.3-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: bugs at FreeBSD.org
          Reporter: freebsdbugs at vanderzwan.org

When remaining time for blacklist entry > 24h the hours shown is incorrect :

                         218.249.24.98/32:25    OK      1/1     2d52h21m44s
                         45.136.108.29/32:587   OK      1/1     1d28h23m49s
                        106.53.185.230/32:25    OK      1/1     1d34h6m15s

The following patch fixes the error:
$ svn diff contrib/blacklist/bin/support.c
Index: contrib/blacklist/bin/support.c
===================================================================
--- contrib/blacklist/bin/support.c     (revision 352893)
+++ contrib/blacklist/bin/support.c     (working copy)
@@ -107,7 +107,7 @@
        t /= 60;
        m = t % 60;
        t /= 60;
-       h = t % 60;
+       h = t % 24;
        t /= 24;
        d = t % 24;
        t /= 356;

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list