[Bug 234793] Failed unknown for $USER in sshd logs even if I got authenticated

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234793

Henry Hu <henry.hu.sh at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |henry.hu.sh at gmail.com

--- Comment #23 from Henry Hu <henry.hu.sh at gmail.com> ---
This bug was introduced in https://reviews.freebsd.org/rS339216. In this
commit, a wrapper was added for login_getpwclass. The line in the dispatch
table says:
    {MONITOR_REQ_GETPWCLASS, MON_AUTH, mm_answer_login_getpwclass},

Because the flag is MON_AUTH, which includes MON_AUTHDECIDE, which means
#define MON_AUTHDECIDE  0x0008  /* Decides Authentication */
So the result of this wrapped call is recorded through auth_log() at line 339
of monitor.c:
https://svnweb.freebsd.org/base/head/crypto/openssh/monitor.c?view=markup#l343

mm_answer_login_getpwclass only retrieves some information from logincap, so it
does not decide the authentication result, and it always returns 0. Thus, I
think that the flag is incorrectly set. I think that the correct value should
be MON_ISAUTH.

-- 
You are receiving this mail because:
You are the assignee for the bug.