[Bug 238223] Kernel fails to build: random_infra.c control reaches end of non-void function

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed May 29 21:19:48 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238223

Conrad Meyer <cem at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |In Progress
                 CC|                            |markm at FreeBSD.org
           Assignee|bugs at FreeBSD.org            |cem at freebsd.org

--- Comment #1 from Conrad Meyer <cem at freebsd.org> ---
Weird, I guess you're using RANDOM_LOADABLE?  The implementation is trivially
broken (my fault) in r346282.

Fix is:

--- a/sys/dev/random/random_infra.c
+++ b/sys/dev/random/random_infra.c
@@ -198,9 +198,12 @@ read_random(void *buf, u_int len)
 bool
 is_random_seeded(void)
 {
+       bool result;
+
        RANDOM_CONFIG_S_LOCK();
-       random_reader_context.is_random_seeded();
+       result = random_reader_context.is_random_seeded();
        RANDOM_CONFIG_S_UNLOCK();
+       return (result);
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list