[Bug 238138] [PATCH] acpi_dock(4): Notify devd(8) on dock status change

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon May 27 18:57:19 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238138

Mark Johnston <markj at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bugs at FreeBSD.org            |markj at FreeBSD.org

--- Comment #4 from Mark Johnston <markj at FreeBSD.org> ---
(In reply to Muhammad Kaisar Arkhan from comment #3)
Thanks.  I applied the patches to my tree.  A couple more comments:
- Please use tabs for indentation next time.  The style(9) man page documents
the kernel coding style.  Admittedly, some of the ACPI code does not follow it
very well.
- Why do you check for a running devd?  Other ACPI subsystems don't bother. 
The event message is non-blocking and we will simply free the message if devd
isn't running.  We save some unnecessary work by checking first, but I'd rather
be consistent with the rest of the kernel unless there's a good reason here.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list