[Bug 238037] [PATCH] Implement ig4 suspend/resume

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238037

            Bug ID: 238037
           Summary: [PATCH] Implement ig4 suspend/resume
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: bugs at FreeBSD.org
          Reporter: ashafer at badland.io

Created attachment 204527
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=204527&action=edit
ig4 suspend/resume patch

ig4(4) does not support suspend/resume at the moment. Fixes Asus i2c touchpads
not working after resuming.

This patch saves all writable registers to a field in the device's ig4iic_softc
struct, and restores them after resuming. It seems like iicbus and iic should
also have the bus_generic_* devmethods added to them in case i2c devices want
to have their suspend/resume methods called? I didn't include it in this patch
but I can easily add it.

A week ago I took a stab at running -CURRENT on my roommate's Asus Q405U. I
used the following review to get the touchpad to work. The touchpad stops
working after resuming (although aside from this the laptop resumes
wonderfully). I don't have physical access to the machine anymore so I'm
submitting this in the hopes that someone else will find it useful.

iichid support: https://reviews.freebsd.org/D16698

(A weird quirk with the above patch on the Q405U is I sometimes had to run 'i2c
-s -f /dev/iic1' like someone so nicely mentioned in the comments. I think this
is the last issue before the newer Asus laptops work fully on -CURRENT)

I'm new to this, so please let me know if there is anything I need to fix.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.