[Bug 238659] ocs_fc: print instance_index value rather than pointer itself in ocs_cam.c

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Jun 17 11:29:30 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238659

            Bug ID: 238659
           Summary: ocs_fc: print instance_index value rather than pointer
                    itself  in ocs_cam.c
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: bugs at FreeBSD.org
          Reporter: huangfq.daxian at gmail.com

Created attachment 205177
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=205177&action=edit
The patch file

In function ocs_scsi_recv_tmf, print instance_index rather than
the pointer itself to avoid printing out kernel pointer to user space.

 sys/dev/ocs_fc/ocs_cam.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/dev/ocs_fc/ocs_cam.c b/sys/dev/ocs_fc/ocs_cam.c
index 7efdc7a07ed..5de22d5f5f2 100644
--- a/sys/dev/ocs_fc/ocs_cam.c
+++ b/sys/dev/ocs_fc/ocs_cam.c
@@ -679,8 +679,8 @@ int32_t ocs_scsi_recv_tmf(ocs_io_t *tmfio, uint64_t lun,
ocs_scsi_tmf_cmd_e cmd,
                trsrc = &fcp->targ_rsrc_wildcard;
        }

-       device_printf(tmfio->ocs->dev, "%s: io=%p cmd=%#x LU=%lx en=%s\n",
-                       __func__, tmfio, cmd, (unsigned long)lun,
+       device_printf(tmfio->ocs->dev, "%s: io=%u(index) cmd=%#x LU=%lx
en=%s\n",
+                       __func__, tmfio->instance_index, cmd, (unsigned
long)lun,
                        trsrc ? (trsrc->enabled ? "T" : "F") : "X");
        if (trsrc) {
                inot = (struct ccb_immediate_notify
*)STAILQ_FIRST(&trsrc->inot);

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-bugs mailing list