[Bug 68437] [patch] conscontrol(8) DEVDIR -> _PATH_DEV fix and more

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=68437

Oleksandr Tymoshenko <gonzo at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |Rejected
             Status|Open                        |Closed
                 CC|                            |gonzo at FreeBSD.org

--- Comment #2 from Oleksandr Tymoshenko <gonzo at FreeBSD.org> ---
I don't think the gain from style clean up is significant enough for a commit. 

The proposed change, in my opinion, would be fine for actively developed code
but amount of effort that would be spent on re-verification of well-tested and
established functionality is not worth the benefits of moving things around a
bit. 

Also adding check for conditions that is not part of current spec and might (or
might not) happen in the future is not a good practice.

If anybody wants to pick up the patch and commit it feel free to reopen the PR.

-- 
You are receiving this mail because:
You are the assignee for the bug.