[Bug 232527] bsd.prog.mk includes bsd.nls.mk unconditionally.

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232527

jarrod at downtools.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jarrod at downtools.com.au

--- Comment #1 from jarrod at downtools.com.au ---
With the same options in src.conf, this also appears to affect the building of
some ports under Poudriere as bsd.nls.mk is also blindly included by
share/mk/bsd.lib.mk (releng/12.0 r340773 line 440).

===>  Building for libsunacl-1.0.1
make[1]: "/usr/share/mk/bsd.opts.mk" line 101: warning: "NO_PROFILE is defined,
but deprecated. Please use MK_PROFILE=no instead."
make[1]: "/usr/share/mk/bsd.lib.mk" line 440: Could not find bsd.nls.mk
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in /wrkdirs/usr/ports/sysutils/libsunacl/work/libsunacl-1.0.1
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/libsunacl

According to tools/build/mk/OptionalObsoleteFiles.inc (releng/12.0 r338929 line
6283), which is included by ObsoleteFiles.inc, usr/share/mk/bsd.nls.mk is
considered optional (well, assuming my interpretation is correct) when NLS
support is disabled therefor is deleted on a "make delete-old".

.if ${MK_NLS} == no
OLD_DIRS+=usr/share/nls/
OLD_DIRS+=usr/share/nls/C
OLD_FILES+=usr/share/mk/bsd.nls.mk  <-- this one here
OLD_FILES+=usr/share/nls/C/ee.cat
OLD_DIRS+=usr/share/nls/af_ZA.ISO8859-1

If this is the case, the file cannot be relied upon and should be .sinclude'd
instead or unmarked as being optional in OptionalObsoleteFiles.inc.  Probably
the latter is the safer?

-- 
You are receiving this mail because:
You are the assignee for the bug.