[Bug 235085] [PATCH] Option to make rc.d/sysctl more verbose (again)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235085

            Bug ID: 235085
           Summary: [PATCH] Option to make rc.d/sysctl more verbose
                    (again)
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: conf
          Assignee: bugs at FreeBSD.org
          Reporter: olli at FreeBSD.org
             Flags: mfc-stable11?, mfc-stable12?

Created attachment 201290
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=201290&action=edit
Patch to add "sysctl_verbose" rc.conf variable.

Several years ago, the output from sysctl(8) commands inside rc.d/sysctl was
visible during boot and logged to console.log (if enabled). That was useful
because you could see the default values of the sysctl variables that were
changed during boot. For example, I have "vfs.ufs.dirhash_maxmem=33554432" (and
other things) in my /etc/sysctl.conf because of recommendations from mailing
lists several years ago. I can see the change in my console.log:

Oct  3 13:17:38 hexagon kernel: vfs.ufs.dirhash_maxmem: 26963968 -> 33554432

However, that output was disabled by r179965:

https://svnweb.freebsd.org/base/head/libexec/rc/rc.d/sysctl?r1=174438&r2=179965

Now it is impossible (or very difficult at least) to find out what the default
value was. For example, when I update from FreeBSD 11 to 12, maybe the default
value of vfs.ufs.dirhash_maxmem changed, so maybe I have to adapt my
/etc/sysctl.conf, but I can't easily find out if that's really the case.

The patch attached to this PR introduces a new rc.conf variable
"sysctl_verbose". The default is "NO", so the current behavior is not changed.
If set to "YES", the output caused by /etc/sysctl.conf is not suppressed, so
any changes made to sysctl variables during boot are visible, as has been the
case until r179965.

The patch was made for HEAD, but it applies as well to stable/12 and stable/11
(the rc.d/sysctl script is the same on all branches). So MFC should be no
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.