[Bug 234413] quotactl() returns wrong error

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234413

topical <topical at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |topical at gmx.net

--- Comment #9 from topical <topical at gmx.net> ---
Samba logs an error according to

  if (errno != ENOTSUP && errno != EINVAL) 

So, to avoid excessive logging, it would be nice to replace the error code with
either ENOTSUP or EINVAL. IMHO it makes more sense to use ENOTSUP but this code
is not documented in quotactl(2) at all. For UFS compatibility, we should use
EINVAL but according to man page, this error code is not applicable. 

I suggest to use ENOTSUP if there is no zfs quota.

-- 
You are receiving this mail because:
You are the assignee for the bug.