[Bug 235944] jedec_dimm(4) does not attach to KFA2 (aka Galax) Hall of Fame DDR4 sticks

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235944

--- Comment #21 from Andriy Gapon <avg at FreeBSD.org> ---
Sorry, I've been inattentive again.
What if that bit lies, e.g., because of a vendor's mistake...
Then, we would fail here:
        if (byte & 0x80) {
                tsod_present = true;
                rc = jedec_dimm_readw_be(sc, TSOD_REG_MANUFACTURER, &vendorid);
                if (rc != 0) {
                        device_printf(dev,
                            "failed to read TSOD Manufacturer ID\n");
                        goto out;
                }

And we see that in comment #0:
> jedec_dimm0: failed to read TSOD Manufacturer ID
> device_attach: jedec_dimm0 attach returned 1

P.S. it also seems that smbus error codes ideally need translating to "normal"
error codes.

-- 
You are receiving this mail because:
You are the assignee for the bug.