[Bug 230792] sort -R, --random-source issues
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Thu Apr 4 23:33:05 UTC 2019
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230792
--- Comment #3 from commit-hook at freebsd.org ---
A commit references this bug:
Author: cem
Date: Thu Apr 4 23:32:27 UTC 2019
New revision: 345896
URL: https://svnweb.freebsd.org/changeset/base/345896
Log:
sort(1): randomcoll: Skip the memory allocation entirely
There's no reason to order based on strcmp of ASCII digests instead of
memcmp of the raw digests.
While here, remove collision fallback. If you collide two MD5s, they're
probably the same string anyway. If robustness against MD5 collisions is
desired, maybe we shouldn't use MD5.
None of the behavior of sort -R is specified by POSIX, so we're free to
implement this however we like. E.g., using a 128-bit counter and block
cipher
to generate unique indices for each line of input.
PR: 230792 (2/many)
Relnotes: This will change the sort order for a given dataset with a
given seed. Other similarly breaking changes are planned.
Sponsored by: Dell EMC Isilon
Changes:
head/usr.bin/sort/coll.c
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-bugs
mailing list